Signal K's AC phase metadata fixed
A pull request written with Claude Code fixes a pattern that matched unrelated paths and left single-phase AC values in Signal K without units.
Credits
- Source byline keesverruijt Source ↗
Earliest dated source:
The full story
In Signal K's path metadata, the AC phase keys used an ungrouped pattern that split into two: one matched any path ending in A, B or C current, so a made-up path got units in amps, and the other had no end anchor, so every value under single-phase AC inherited the container's description and lost its units.
This pull request, generated with Claude Code, groups the pattern correctly and defines generator and inverter phase paths explicitly, since those had only had units through the accidental match. Running canboat's sample logs through the parser shows no metadata change across the 689 paths written, and new tests reject unrelated paths and phase D.
How it was done
Tools
Themes
Loading themes…
Sources
From the maker's own write-up or code. We summarise what they report; we haven't tested it ourselves.
- Signal K Server: fix(path-metadata): AC phase metadata matched unrelated paths and gave single-phase values no unitsSource byline: keesverruijtPublished
The pull request on GitHub.